[PATCH 2/3] staging: speakup: use native error codes
Dan Carpenter
dan.carpenter at oracle.com
Mon Apr 1 09:29:49 UTC 2013
On Wed, Mar 27, 2013 at 07:47:07PM +0100, Samuel Thibault wrote:
> Andy Shevchenko, le Wed 27 Mar 2013 17:44:56 +0200, a écrit :
> > The mapping as follows:
> > E_RANGE -> ERANGE
> > E_UNDEF -> ENODATA
> > E_TOOLONG -> E2BIG
> >
> >
> > #define SET_DEFAULT -4
> > -#define E_RANGE -3
> > -#define E_TOOLONG -2
> > -#define E_UNDEF -1
>
> We need to change SET_DEFAULT too, otherwise nothing really says (or at
> least document) that it's different from ERANGE, ENODATA and E2BIG. I'm
> not sure which E* would be fine. Perhaps ERESTART?
There is no point to SET_DEFAULT. It should just return success and
not print anything.
regards,
dan carpenter
More information about the devel
mailing list