drivers/staging/comedi/drivers/ni_pcimio.c:1694 pcimio_attach_pci() warn: 'dev->irq' was not released on error

Fengguang Wu fengguang.wu at intel.com
Thu Sep 27 00:54:32 UTC 2012


Hi Bill, Ian,

FYI, this smatch warning probably exists from day 0 of the driver
code:

+ drivers/staging/comedi/drivers/ni_pcimio.c:1694 pcimio_attach_pci() warn: 'dev->irq' was not released on error

vim +1694 drivers/staging/comedi/drivers/ni_pcimio.c
  1678		dev->irq = mite_irq(devpriv->mite);
  1679	
  1680		if (dev->irq == 0) {
  1681			pr_warn("unknown irq (bad)\n");
  1682		} else {
  1683			pr_debug("( irq = %u )\n", dev->irq);
  1684			ret = request_irq(dev->irq, ni_E_interrupt, NI_E_IRQ_FLAGS,
  1685					  DRV_NAME, dev);
  1686			if (ret < 0) {
  1687				pr_warn("irq not available\n");
  1688				dev->irq = 0;
  1689			}
  1690		}
  1691	
  1692		ret = ni_E_init(dev);
  1693		if (ret < 0)
> 1694			return ret;
  1695	
  1696		dev->subdevices[NI_AI_SUBDEV].buf_change = &pcimio_ai_change;
  1697		dev->subdevices[NI_AO_SUBDEV].buf_change = &pcimio_ao_change;
  1698		dev->subdevices[NI_GPCT_SUBDEV(0)].buf_change = &pcimio_gpct0_change;
  1699		dev->subdevices[NI_GPCT_SUBDEV(1)].buf_change = &pcimio_gpct1_change;
  1700		dev->subdevices[NI_DIO_SUBDEV].buf_change = &pcimio_dio_change;
  1701	
  1702		return ret;

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation



More information about the devel mailing list