[PATCH 5/8] Staging: bcm: Remove typedef for _stServiceFlowParamSI and call directly.

Kevin McKinney klmckinney1 at gmail.com
Sat Sep 22 22:06:25 UTC 2012

On Sat, Sep 22, 2012 at 7:09 AM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Sat, Sep 22, 2012 at 01:24:36AM -0400, Kevin McKinney wrote:
>> This patch removes typedef for _stServiceFlowParamSI,
>> and changes the name of the struct to
>> bcm_service_flow. In addition, any
>> calls to typedefs "stServiceFlowParamSI,
>> *pstServiceFlowParamSI, CServiceFlowParamSI"
>> are changed to call the struct directly.
> This name isn't right.  These varaibles are all Service Flow
> variables, it's just that the other ones used SF instead of typing
> it all out.  (I have no idea what Service Flow means).
> I also don't know what SI means.
> I don't know what the right name is here...  I think it should
> involve "param" or something similar but I'm going to let you figure
> it out.  :P  Can you redo this one?
> Also the comments need to be updated.

Okay, I will change the name and resubmit.

> regards,
> dan carpenter

More information about the devel mailing list