[PATCH 06/17] staging: comedi: s526: remove unneeded check in s526_gpct_rinsn()

H Hartley Sweeten hartleys at visionengravers.com
Wed Sep 19 22:09:57 UTC 2012


The comedi core validates insn->n before calling this function.
Remove the unnecessary check.

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/s526.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/s526.c b/drivers/staging/comedi/drivers/s526.c
index 75e3e58..f9f0fda 100644
--- a/drivers/staging/comedi/drivers/s526.c
+++ b/drivers/staging/comedi/drivers/s526.c
@@ -217,11 +217,6 @@ static int s526_gpct_rinsn(struct comedi_device *dev,
 	unsigned short datalow;
 	unsigned short datahigh;
 
-	/*  Check if (n > 0) */
-	if (insn->n <= 0) {
-		printk(KERN_ERR "s526: INSN_READ: n should be > 0\n");
-		return -EINVAL;
-	}
 	/*  Read the low word first */
 	for (i = 0; i < insn->n; i++) {
 		datalow = inw(dev->iobase + REG_C0L + counter_channel * 8);
-- 
1.7.11




More information about the devel mailing list