[PATCH v3] staging/gdm72xx: usb_boot: replace firmware upgrade API in em_download

[Greg Kroah-Hartman]

On Mon, Sep 17, 2012 at 08:46:01PM +0800, Macpaul Lin wrote:
> Hi Greg,
> 
> 2012/9/17 Greg Kroah-Hartman <gregkh at linuxfoundation.org>:
> > On Fri, Sep 14, 2012 at 02:02:04PM +0800, Macpaul Lin wrote:
> >> Replace firmware upgrade API in em_download_image().
> 
> >>  #define FW_UIMG                      "gdmuimg.bin"
> >> -#define KERN_PATH            "/lib/firmware/gdm72xx/zImage"
> >> -#define FS_PATH                      "/lib/firmware/gdm72xx/ramdisk.jffs2"
> >> +#define FW_KERN                      "zImage"
> >> +#define FW_FS                        "ramdisk.jffs2"
> >
> > For some reason, I don't think that this really is your "firmware" name,
> > right?  That looks like a kernel and a filesystem name.
> >
> > What is going on here with this code?  Why would the kernel load a
> > kernel?
> >
> 
> I think (guess) the gdmuimg.bin is a combination of Linux kernel and ramdisk.
> The GDM72xx USB WiMAX dongle itself contains a Linux system
> which is responsible to deal with the traffic between WiMAX radio and
> USB interface.
> I think em_download_image() for this USB dongle will be used
> when the Linux system on it has been broken and the dongle itself could not
> extract kernel and ramdisk from the firmware image.

Ah, ok, I didn't think of Linux running on the device itself, but that
makes sense.  I'll go queue this up, thanks.

greg k-h