[PATCH 3/5] staging: ipack: remove irq field in struct ipack_device.
Samuel Iglesias Gonsálvez
siglesias at igalia.com
Thu Sep 13 10:33:04 UTC 2012
On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge <jens.taprogge at taprogge.org>
> >
> > The field irq currently is identical to the slot number. It does not seem to
> > have any real use. The number is written to hardware in ipoctal but it seems
> > the value that is written does not matter.
> >
> > Signed-off-by: Jens Taprogge <jens.taprogge at taprogge.org>
> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> > ---
> > - iowrite8(vector, ipoctal->dev->mem_space.address + 1);
> > + iowrite8(1, ipoctal->dev->mem_space.address + 1);
>
> It might be nice to put a /* dummy write */ comment here.
>
Added! Thanks for the suggestion,
Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120913/74014265/attachment.asc>
More information about the devel
mailing list