[PATCH] Staging: silicom: checkpatch: cleanup macros

Greg KH greg at kroah.com
Tue Sep 11 21:00:09 UTC 2012


On Tue, Sep 11, 2012 at 09:29:06PM -0700, DanielC wrote:
> 
> Staging: silicom: checkpatch cleanup: macros
> 
> Signed-off-by: Daniel Cotey <puff65537 at bansheeslibrary.com>

Since you are starting to send a lot of patches, let's get the format
down so it makes my life easier to apply these.

First off, your "From:" line doesn't have the same name as your
Signed-off-by: line does.  Please fix that.

Second, what's with repeating the subject line in the body of the email
here?  That's not needed, and is redundant, and is a poor excuse for
putting something "real" in the body of the email.

Third, you sent 3 patches, what order should I apply them in?  Please
use the correct [01/03] type marking in the subject: line to show
ordering of patches, so I know how to apply them in.

Care to redo these three patches with this all fixed up, so that I can
apply them?

thanks,

greg k-h



More information about the devel mailing list