bcm

[Kevin McKinney]

On Tue, Sep 11, 2012 at 9:25 AM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Tue, Sep 11, 2012 at 06:33:19AM +0600, Rinat Camalov wrote:
>>
>> CC the devel list ?????? What is that?
>
> Add this to the CC list:  devel at driverdev.osuosl.org
>
> You're not using the upstream code?  Can you try compiling the 3.5
> kernel?  It's not going to work either, but at least we'll all be
> using the same source.
>
> This driver is so full of absolute crap, but there wasn't anyone to
> test it.  And we thought it didn't work at all anyway so it was
> discouraging.

Yeah, I still can't test this driver.

> These warnings are still there and there is a comment that the
> code can't possibly be right (on 64 bit).  So that's one place to
> start.
>
>> /home/richman/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
>> /home/richman/bcm/CmHost.c:1401:39: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> /home/richman/bcm/CmHost.c:1440:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> /home/richman/bcm/CmHost.c:1454:35: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

This is a really tough one to crack.  I tried looking at this once
last year.  I will give it another shot.

> Also the whole driver just needs cleaned up.  If someone did that
> they would find a ball of things to fix.

I know we did a lot of cleanup in the past. I will look to see other
files that need to be addressed.  But I did not think there was a ton.
 Are you saying we still have a long way to go on the cleanup effort?

Thanks,
Kevin