[PATCH 22/46] staging: comedi: adl_pci9111: remove the board attach noise

H Hartley Sweeten hartleys at visionengravers.com
Tue Sep 11 01:59:21 UTC 2012


Remove the kernel messages about the io base/range for the pci
resources.

Move the board attach messages to the end of the attach and use
a simple/clean dev_info message for it.

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/adl_pci9111.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c b/drivers/staging/comedi/drivers/adl_pci9111.c
index 38faa46..f30bcb7 100644
--- a/drivers/staging/comedi/drivers/adl_pci9111.c
+++ b/drivers/staging/comedi/drivers/adl_pci9111.c
@@ -1098,10 +1098,6 @@ static int pci9111_attach(struct comedi_device *dev,
 	dev_private = dev->private;
 
 	/*  Probe the device to determine what device in the series it is. */
-
-	printk(KERN_ERR "comedi%d: " PCI9111_DRIVER_NAME " driver\n",
-								dev->minor);
-
 	pcidev = pci9111_find_pci(dev, it);
 	if (!pcidev)
 		return -EIO;
@@ -1116,10 +1112,6 @@ static int pci9111_attach(struct comedi_device *dev,
 	lcr_io_base = pci_resource_start(pcidev, 1);
 	lcr_io_range = pci_resource_len(pcidev, 1);
 
-	printk
-	    ("comedi%d: local configuration registers at address 0x%4lx [0x%4lx]\n",
-	     dev->minor, lcr_io_base, lcr_io_range);
-
 	/*  Enable PCI device and request regions */
 	if (comedi_pci_enable(pcidev, PCI9111_DRIVER_NAME) < 0) {
 		printk
@@ -1132,9 +1124,6 @@ static int pci9111_attach(struct comedi_device *dev,
 	io_base = pci_resource_start(pcidev, 2);
 	io_range = pci_resource_len(pcidev, 2);
 
-	printk(KERN_ERR "comedi%d: 6503 registers at address 0x%4lx [0x%4lx]\n",
-	       dev->minor, io_base, io_range);
-
 	dev->iobase = io_base;
 	dev->board_name = board->name;
 	dev_private->io_range = io_range;
@@ -1207,6 +1196,8 @@ static int pci9111_attach(struct comedi_device *dev,
 
 	dev_private->is_valid = 1;
 
+	dev_info(dev->class_dev, "%s attached\n", dev->board_name);
+
 	return 0;
 }
 
-- 
1.7.11




More information about the devel mailing list