[staging-next V3] ozwpan: fix memcmp() test in oz_set_active_pd()

Dan Carpenter dan.carpenter at oracle.com
Tue Sep 4 17:34:28 UTC 2012


On Sun, Aug 19, 2012 at 07:36:37PM +0300, Tomas Winkler wrote:
> "addr" is a pointer so it's either 4 or 8 bytes, but actually we want
> to compare 6 bytes (ETH_ALEN).
> 
> As network stack already provides helper function
> is_zero_ether_addr() we use that instead of memcmp
> 
> Signed-off-by: Tomas Winkler <tomas.winkler at intel.com>
> Cc: Dan Carpenter <dan.carpenter at oracle.com>
> Cc: Rupesh Gujare <rgujare at ozmodevices.com>
> ---
> V1: by Dan Carpenter <dan.carpenter at oracle.com>
> V2: replace memcmp with is_zero_ether_addr
> V3: include <linux/etherdevice.h>
> 

Acked-by: Dan Carpenter <dan.carpenter at oracle.com>

regards,
dan carpenter




More information about the devel mailing list