[PATCH] staging: csr: fix possible memory leak in do_patch_convert_download()

Wei Yongjun weiyj.lk at gmail.com
Mon Sep 3 10:15:26 UTC 2012

From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

pfw has been allocated in function xbv_to_patch() and should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.

Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
 drivers/staging/csr/csr_wifi_hip_download.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/csr/csr_wifi_hip_download.c b/drivers/staging/csr/csr_wifi_hip_download.c
index 8e4a460..6db672c 100644
--- a/drivers/staging/csr/csr_wifi_hip_download.c
+++ b/drivers/staging/csr/csr_wifi_hip_download.c
@@ -250,6 +250,7 @@ static CsrResult do_patch_convert_download(card_t *card, void *dlpriv, xbv1_t *p
         if (r != CSR_RESULT_SUCCESS)
             unifi_error(card->ospriv, "Failed to find BOOT_LOADER_CONTROL\n");
+            kfree(pfw);
             return CSR_RESULT_FAILURE;
@@ -265,6 +266,7 @@ static CsrResult do_patch_convert_download(card_t *card, void *dlpriv, xbv1_t *p
         desc = unifi_fw_open_buffer(card->ospriv, pfw, psize);
         if (!desc)
+            kfree(pfw);
             return CSR_WIFI_HIP_RESULT_NO_MEMORY;

More information about the devel mailing list