[PATCH 00/29] staging: addi-data: cleanup round 2

H Hartley Sweeten hartleys at visionengravers.com
Tue Oct 30 23:53:12 UTC 2012 

The addi-data drivers are a bit of a mess and have a ot of bloat.

The source files listed in the Makefile do a bunch of #include's of
other c files to build the final drivers. This is a maintenance
nightmare and just makes the drivers difficult to follow.

Since these drivers are build by c files including other c files,
all the functions are really static and do not need to be exposed
to the kernel. Make all the functions static and move them as
necessary to remove the need for all the forward declarations.

In the files that need functions moved in order to get rid of the
forward declarations, also remove/reword the ugly function comments.
For now leave any details that might help when actually cleaning up
the code.

Absorb all the unnecessary private headers into the associated
source files.

If nothing else, this series deletes 23 unnecessary headers and
removes 1726 lines of cruft.

H Hartley Sweeten (29):
  staging: comedi: hwrdv_apci035: absorb private header
  staging: comedi: hwrdv_apci1032: absorb private header
  staging: comedi: hwrdv_apci1500: absorb private header
  staging: comedi: hwrdv_apci1516: absorb private header
  staging: comedi: hwrdv_apci1564: absorb private header
  staging: comedi: hwrdv_apci16xx absorb private header
  staging: comedi: hwrdv_apci2016: absorb private header
  staging: comedi: hwrdv_apci2032: absorb private header
  staging: comedi: hwrdv_apci2200: absorb private header
  staging: comedi: hwrdv_apci3501: absorb private header
  staging: comedi: hwrdv_apci3xxx: absorb private header
  staging: comedi: hwdrv_apci3120: remove forward declarations
  staging: comedi: hwrdv_apci3120: absorb private header
  staging: comedi: APCI1710_Ttl: absorb private header
  staging: comedi: APCI1710_Tor: absorb private header
  staging: comedi: APCI1710_Ssi: absorb private header
  staging: comedi: APCI1710_Inp_cpt: absorb private header
  staging: comedi: APCI1710_Dig_io: absorb private header
  staging: comedi: APCI1710_82x54: remove forward declarations
  staging: comedi: APCI1710_82x54: absorb private header
  staging: comedi: APCI1710_Chrono: remove forward declarations
  staging: comedi: APCI1710_Chrono: absorb private header
  staging: comedi: APCI1710_INCCPT: remove forward declarations
  staging: comedi: APCI1710_INCCPT: absorb private header
  staging: comedi: APCI1710_Pwm: remove forward declarations
  staging: comedi: APCI1710_Pwm: absorb private header
  staging: comedi: hwdrv_apci3200: remove forward declarations
  staging: comedi: hwdrv_apci3200: absorb private header
  staging: comedi: hwdrv_APCI1710: absorb private header

 .../comedi/drivers/addi-data/APCI1710_82x54.c      |  197 +-
 .../comedi/drivers/addi-data/APCI1710_82x54.h      |   73 -
 .../comedi/drivers/addi-data/APCI1710_Chrono.c     |  240 +-
 .../comedi/drivers/addi-data/APCI1710_Chrono.h     |   74 -
 .../comedi/drivers/addi-data/APCI1710_Dig_io.c     |   16 +-
 .../comedi/drivers/addi-data/APCI1710_Dig_io.h     |   25 -
 .../comedi/drivers/addi-data/APCI1710_INCCPT.c     |  848 ++---
 .../comedi/drivers/addi-data/APCI1710_INCCPT.h     |  271 --
 .../comedi/drivers/addi-data/APCI1710_Inp_cpt.c    |   10 +-
 .../comedi/drivers/addi-data/APCI1710_Inp_cpt.h    |   22 -
 .../comedi/drivers/addi-data/APCI1710_Pwm.c        |  269 +-
 .../comedi/drivers/addi-data/APCI1710_Pwm.h        |   76 -
 .../comedi/drivers/addi-data/APCI1710_Ssi.c        |   19 +-
 .../comedi/drivers/addi-data/APCI1710_Ssi.h        |   31 -
 .../comedi/drivers/addi-data/APCI1710_Tor.c        |   21 +-
 .../comedi/drivers/addi-data/APCI1710_Tor.h        |   33 -
 .../comedi/drivers/addi-data/APCI1710_Ttl.c        |   10 +-
 .../comedi/drivers/addi-data/APCI1710_Ttl.h        |   22 -
 .../comedi/drivers/addi-data/hwdrv_APCI1710.c      |   57 +-
 .../comedi/drivers/addi-data/hwdrv_APCI1710.h      |   70 -
 .../comedi/drivers/addi-data/hwdrv_apci035.c       |   74 +-
 .../comedi/drivers/addi-data/hwdrv_apci035.h       |   83 -
 .../comedi/drivers/addi-data/hwdrv_apci1032.c      |   31 +-
 .../comedi/drivers/addi-data/hwdrv_apci1032.h      |   42 -
 .../comedi/drivers/addi-data/hwdrv_apci1500.c      |  100 +-
 .../comedi/drivers/addi-data/hwdrv_apci1500.h      |  115 -
 .../comedi/drivers/addi-data/hwdrv_apci1516.c      |   24 +-
 .../comedi/drivers/addi-data/hwdrv_apci1516.h      |   35 -
 .../comedi/drivers/addi-data/hwdrv_apci1564.c      |   69 +-
 .../comedi/drivers/addi-data/hwdrv_apci1564.h      |   78 -
 .../comedi/drivers/addi-data/hwdrv_apci16xx.c      |   28 +-
 .../comedi/drivers/addi-data/hwdrv_apci16xx.h      |   40 -
 .../comedi/drivers/addi-data/hwdrv_apci2016.c      |   27 +-
 .../comedi/drivers/addi-data/hwdrv_apci2016.h      |   37 -
 .../comedi/drivers/addi-data/hwdrv_apci2032.c      |   42 +-
 .../comedi/drivers/addi-data/hwdrv_apci2032.h      |   52 -
 .../comedi/drivers/addi-data/hwdrv_apci2200.c      |   22 +-
 .../comedi/drivers/addi-data/hwdrv_apci2200.h      |   33 -
 .../comedi/drivers/addi-data/hwdrv_apci3120.c      | 1687 +++++-----
 .../comedi/drivers/addi-data/hwdrv_apci3120.h      |  248 --
 .../comedi/drivers/addi-data/hwdrv_apci3200.c      | 3243 +++++++++-----------
 .../comedi/drivers/addi-data/hwdrv_apci3200.h      |  190 --
 .../comedi/drivers/addi-data/hwdrv_apci3501.c      |   43 +-
 .../comedi/drivers/addi-data/hwdrv_apci3501.h      |   52 -
 .../comedi/drivers/addi-data/hwdrv_apci3xxx.c      |   35 +-
 .../comedi/drivers/addi-data/hwdrv_apci3xxx.h      |   48 -
 46 files changed, 3568 insertions(+), 5294 deletions(-)
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_82x54.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Chrono.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Dig_io.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_INCCPT.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Inp_cpt.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Pwm.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Ssi.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Tor.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Ttl.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_APCI1710.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci1032.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci1516.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci16xx.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci2016.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci2032.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci2200.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.h
 delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci3xxx.h

-- 
1.7.11

More information about the devel mailing list