[PATCH 10/27] staging: comedi: addi_eeprom: cleanup v_EepromSendCommand76()

H Hartley Sweeten hartleys at visionengravers.com
Tue Oct 30 00:05:17 UTC 2012


Add namespace to the function by renaming the CamelCase function to
addi_eeprom_cmd_93c76().

Rename the CamelCase parameters and local variables.

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 .../staging/comedi/drivers/addi-data/addi_eeprom.c | 26 +++++++++++-----------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi-data/addi_eeprom.c b/drivers/staging/comedi/drivers/addi-data/addi_eeprom.c
index 0f7eaae..dfe44c9 100644
--- a/drivers/staging/comedi/drivers/addi-data/addi_eeprom.c
+++ b/drivers/staging/comedi/drivers/addi-data/addi_eeprom.c
@@ -121,29 +121,29 @@ static void addi_eeprom_clk_93c76(unsigned long iobase, unsigned int val)
 	udelay(100);
 }
 
-static void v_EepromSendCommand76(unsigned long iobase,
-				  unsigned int dw_EepromCommand,
-				  unsigned char b_DataLengthInBits)
+static void addi_eeprom_cmd_93c76(unsigned long iobase,
+				  unsigned int cmd,
+				  unsigned char len)
 {
-	unsigned int dw_RegisterValue = EE93C76_CS_BIT;
-	char c_BitPos = 0;
+	unsigned int val = EE93C76_CS_BIT;
+	int i;
 
 	/* Toggle EEPROM's Chip select to get it out of Shift Register Mode */
-	outl(dw_RegisterValue, iobase);
+	outl(val, iobase);
 	udelay(100);
 
 	/* Send EEPROM command - one bit at a time */
-	for (c_BitPos = (b_DataLengthInBits - 1); c_BitPos >= 0; c_BitPos--) {
-		if (dw_EepromCommand & (1 << c_BitPos))
-			dw_RegisterValue = dw_RegisterValue | EE93C76_DOUT_BIT;
+	for (i = (len - 1); i >= 0; i--) {
+		if (cmd & (1 << i))
+			val |= EE93C76_DOUT_BIT;
 		else
-			dw_RegisterValue = dw_RegisterValue & ~EE93C76_DOUT_BIT;
+			val &= ~EE93C76_DOUT_BIT;
 
 		/* Write the command */
-		outl(dw_RegisterValue, iobase);
+		outl(val, iobase);
 		udelay(100);
 
-		addi_eeprom_clk_93c76(iobase, dw_RegisterValue);
+		addi_eeprom_clk_93c76(iobase, val);
 	}
 }
 
@@ -156,7 +156,7 @@ static void v_EepromCs76Read(unsigned long iobase,
 	unsigned int dw_RegisterValueRead = 0;
 
 	/* Send EEPROM read command and offset to EEPROM */
-	v_EepromSendCommand76(iobase, (EE_READ << 4) | (w_offset / 2),
+	addi_eeprom_cmd_93c76(iobase, (EE_READ << 4) | (w_offset / 2),
 		EE76_CMD_LEN);
 
 	/* Get the last register value */
-- 
1.7.11




More information about the devel mailing list