[PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup()
KY Srinivasan
kys at microsoft.com
Thu Oct 25 14:13:28 UTC 2012
> -----Original Message-----
> From: Greg KH [mailto:gregkh at linuxfoundation.org]
> Sent: Wednesday, October 24, 2012 6:45 PM
> To: KY Srinivasan
> Cc: linux-kernel at vger.kernel.org; devel at linuxdriverproject.org; olaf at aepfle.de;
> apw at canonical.com; jasowang at redhat.com
> Subject: Re: [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup()
>
> On Fri, Oct 12, 2012 at 01:22:43PM -0700, K. Y. Srinivasan wrote:
> > hv_ringbuffer_cleanup() is an empty function; get rid of it.
> >
> > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> > Reviewed-by: Haiyang Zhang <haiyangz at microsoft.com>
> > Reported-by: Jason Wang <jasowang at redhat.com>
> > Acked-by: Jason Wang <jasowang at redhat.com>
> > ---
> > drivers/hv/channel.c | 4 ----
> > drivers/hv/hyperv_vmbus.h | 1 -
> > drivers/hv/ring_buffer.c | 11 -----------
> > 3 files changed, 0 insertions(+), 16 deletions(-)
>
> That's nice, but this patch causes build failures, so I can't accept it.
>
> Please test your patches better (hint, a simple 'git grep' would have
> worked here...)
Sorry about that. I am pretty sure I built (with this patch) both vmbus and the util drivers.
This function is a private function for the vmbus driver and in fact I went back and rebuilt the
drivers in the hv directory without any problem (with this patch applied) in the same tree where
I developed these patches (linux-next tree dated October 2, 2012). Specifically, what was
the build problem you ran into.
Regards,
K. Y
More information about the devel
mailing list