[PATCH V4] drivers:staging:ced1401: fix a frame size warning, use smaller memory block is sufficient

Alois Schloegl schloegl at ist.ac.at
Thu Oct 25 12:16:01 UTC 2012


This code fixes a frame size warning. Unlike alternative patches, a smaller structure is used which avoids the use of kmalloc/kfree.

This is faster than the original code. We never do anything other than use element 0, or no elements in linux. This was not the case in Windows, but we ain't in Kansas now, so I think we should go with that. It is a nice tidy solution. "


From: Greg Smith <greg at ced.co.uk>

Signed-off-by: Alois Schloegl <alois.schloegl at ist.ac.at>



diff --git a/use1401.h b/use1401.h
index 86294e2..3e25125 100644
--- a/use1401.h
+++ b/use1401.h
@@ -150,7 +150,7 @@
 #define LONG_SIZE             3           /* 32-bit access                  */
 
 /// Stuff used by U14_GetTransfer
-#define GET_TX_MAXENTRIES  257          /* (max length / page size + 1) */
+#define GET_TX_MAXENTRIES     1	 /* (max length / page size + 1) */
 
 #ifdef _IS_WINDOWS_
 #pragma pack(1)



More information about the devel mailing list