[PATCH 01/19] staging: comedi: cb_pcidda: fix error test in cb_pcidda_attach_pci()

H Hartley Sweeten hartleys at visionengravers.com
Wed Oct 24 23:28:36 UTC 2012


As pointed out by Fengguang Wu, the error test after finding the
boardinfo should be testing for (!thisboard).

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Reported-by: Fengguang Wu <fengguang.wu at intel.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/cb_pcidda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
index 798374f..06e546f 100644
--- a/drivers/staging/comedi/drivers/cb_pcidda.c
+++ b/drivers/staging/comedi/drivers/cb_pcidda.c
@@ -657,7 +657,7 @@ static int cb_pcidda_attach_pci(struct comedi_device *dev,
 	int ret;
 
 	thisboard = cb_pcidda_find_boardinfo(dev, pcidev);
-	if (!pcidev)
+	if (!thisboard)
 		return -ENODEV;
 	dev->board_ptr = thisboard;
 	dev->board_name = thisboard->name;
-- 
1.7.11




More information about the devel mailing list