drivers/staging/comedi/drivers/cb_pcidda.c:660 cb_pcidda_attach_pci() warn: variable dereferenced before check 'pcidev' (see line 659)

Fengguang Wu fengguang.wu at intel.com
Wed Oct 24 04:13:48 UTC 2012


Hi Hartley,

FYI, here is a smatch warning in upstream kernel:

+ drivers/staging/comedi/drivers/cb_pcidda.c:660 cb_pcidda_attach_pci() warn: variable dereferenced before check 'pcidev' (see line 659)

vim +660 drivers/staging/comedi/drivers/cb_pcidda.c

2c0db011 H Hartley Sweeten 2012-08-16 @659  	thisboard = cb_pcidda_find_boardinfo(dev, pcidev);
2c0db011 H Hartley Sweeten 2012-08-16 @660  	if (!pcidev)
2c0db011 H Hartley Sweeten 2012-08-16  661  		return -ENODEV;

It may want to test thisboard rather than pcidev.

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation



More information about the devel mailing list