[PATCH] Staging: bcm: Checkpatch fixes

Denis Kirjanov kirjanov at gmail.com
Tue Oct 23 13:00:36 UTC 2012


It would be better to see a patch which will remove all of this crap
instead of fixing that...

On 10/23/12, Ceri James <jamesceri at googlemail.com> wrote:
> This fixes the following checkpatch issues:
>
> WARNING: line over 80 characters
> +	BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL,
> "=====>\n");
>
> ERROR: space required after that ',' (ctx:VxV)
> +	BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL,
> "=====>\n");
>  	                       ^
> WARNING: line over 80 characters
> +		BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL, "Adapter
> found NULL!\n");
>
> ERROR: space required after that ',' (ctx:VxV)
> +		BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL, "Adapter
> found NULL!\n");
>  		                       ^
>
> Signed-off-by: Ceri James <jamesceri at googlemail.com>
> ---
>  drivers/staging/bcm/LeakyBucket.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm/LeakyBucket.c
> b/drivers/staging/bcm/LeakyBucket.c
> index 6e8a327..877cf0b 100644
> --- a/drivers/staging/bcm/LeakyBucket.c
> +++ b/drivers/staging/bcm/LeakyBucket.c
> @@ -21,10 +21,12 @@ static VOID UpdateTokenCount(register struct
> bcm_mini_adapter *Adapter)
>  	INT 	i = 0;
>  	struct timeval tv;
>
> -	BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL,
> "=====>\n");
> +	BCM_DEBUG_PRINT(Adapter, DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL,
> +			"=====>\n");
>  	if(NULL == Adapter)
>  	{
> -		BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL, "Adapter
> found NULL!\n");
> +		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_TX, TOKEN_COUNTS,
> +				DBG_LVL_ALL, "Adapter found NULL!\n");
>  		return;
>  	}
>
> --
> 1.7.6.5
>
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>


-- 
Regards,
Denis



More information about the devel mailing list