[PATCH 2/9] Staging: winbond: phy_calibration: Fixed coding style issue
Pavel Machek
pavel at ucw.cz
Sun Oct 21 10:38:38 UTC 2012
On Fri 2012-10-12 09:53:19, Joe Perches wrote:
> On Fri, 2012-10-12 at 22:07 +0530, Adil Mujeeb wrote:
> > Removed checkpatch.pl script reported ERRORs
> []
> > diff --git a/linux-3.6-rc7/drivers/staging/winbond/phy_calibration.c b/linux-3.6-rc7/drivers/staging/winbond/phy_calibration.c
> []
> > -#define AG_CONST 0.6072529350
> > +#define AG_CONST (0.6072529350)
>
> That one is unnecessary.
> checkpatch is defective here.
Agreed.
> I wonder why there is any floating point
> in the code at all though.
Some kind of signal strength computations. I'm not an wifi expert... :-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
More information about the devel
mailing list