[PATCH 1/5] staging: csr: sme_blocking.c: clean up tab mess

Dan Carpenter dan.carpenter at oracle.com
Thu Oct 18 12:20:33 UTC 2012


On Tue, Oct 16, 2012 at 11:14:36PM -0700, Sungju Huh wrote:
> From: root <root at ubuntu.(none)>

This line is bogus.  We don't need this from line because we use
your email address.  Also don't work as root.

> 
> This patch converts spaces to tabs.
> 
> Signed-off-by: Sungju Huh <sjhuh at redwood.snu.ac.kr>

Except this isn't the email address that you used to send the email
from.

The From line is for if you are sending patches on behalf of another
person (who is not just you with a using email).  Both people would
need to add a signed off by line.

regards,
dan carpenter





More information about the devel mailing list