[PATCH v2] staging: comedi: jr3_pci: add __iomem tags

Ian Abbott abbotti at mev.co.uk
Tue Oct 16 17:09:58 UTC 2012


On 2012-10-15 19:26, H Hartley Sweeten wrote:
> On Monday, October 15, 2012 4:20 AM, Ian Abbott wrote:
>>
>> Tag pointers to remapped I/O memory with `__iomem` and remove the
>> `volatile` qualifiers.
>>
>> Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
>
> I'm still not a fan of the iobase pointer being a struct * and not a void *.

There are quite a few Linux drivers that use a similar trick though.  Try:

grep -r --include='*.c' 'struct [A-Za-z0-9_]* __iomem' 
/usr/src/linux/drivers

(replacing /usr/src/linux/drivers as appropriate).

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list