[PATCH 9/9] Staging: winbond: wb35tx_s: Fixed coding style issues

Adil Mujeeb mujeeb.adil at gmail.com
Fri Oct 12 16:37:15 UTC 2012


Fixed most of the checkpatch.pl reported ERRORs and WARNINGs.
Some "line over 80 characters" warning left.

Signed-off-by: Adil Mujeeb <mujeeb.adil at gmail.com>
---
 linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h |   49 +++++++++------------
 1 files changed, 21 insertions(+), 28 deletions(-)

diff --git a/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h b/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h
index f70f433..02a1f27 100644
--- a/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h
+++ b/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h
@@ -3,45 +3,38 @@
 
 #include "mds_s.h"
 
-//====================================
-// IS89C35 Tx related definition
-//====================================
-#define TX_INTERFACE			0	// Interface 1
-#define TX_PIPE					3	// endpoint 4
-#define TX_INTERRUPT			1	// endpoint 2
-#define MAX_INTERRUPT_LENGTH	64	// It must be 64 for EP2 hardware
-
-
-
-//====================================
-// Internal variable for module
-//====================================
+/* IS89C35 Tx related definition */
+#define TX_INTERFACE		0	/* Interface 1 */
+#define TX_PIPE			3	/* endpoint 4 */
+#define TX_INTERRUPT		1	/* endpoint 2 */
+#define MAX_INTERRUPT_LENGTH	64	/* It must be 64 for EP2 hardware */
 
+/* Internal variable for module */
 
 struct wb35_tx {
-	// For Tx buffer
-	u8	TxBuffer[ MAX_USB_TX_BUFFER_NUMBER ][ MAX_USB_TX_BUFFER ];
+	/* For Tx buffer */
+	u8		TxBuffer[MAX_USB_TX_BUFFER_NUMBER][MAX_USB_TX_BUFFER];
 
-	// For Interrupt pipe
-	u8	EP2_buf[MAX_INTERRUPT_LENGTH];
+	/* For Interrupt pipe */
+	u8		EP2_buf[MAX_INTERRUPT_LENGTH];
 
-	atomic_t	TxResultCount;// For thread control of EP2 931130.4.m
-	atomic_t	TxFireCounter;// For thread control of EP4 931130.4.n
-	u32			ByteTransfer;
+	atomic_t	TxResultCount; /* For thread control of EP2 931130.4.m */
+	atomic_t	TxFireCounter; /* For thread control of EP4 931130.4.n */
+	u32		ByteTransfer;
 
-	u32	    TxSendIndex;// The next index of Mds array to be sent
-	u32	    EP2vm_state; // for EP2vm state
-	u32	    EP4vm_state; // for EP4vm state
-	u32	    tx_halt; // Stopping VM
+	u32		TxSendIndex; /* next index of Mds array to be sent */
+	u32		EP2vm_state; /* for EP2vm state */
+	u32		EP4vm_state; /* for EP4vm state */
+	u32		tx_halt; /* Stopping VM */
 
-	struct urb *				Tx4Urb;
-	struct urb *				Tx2Urb;
+	struct urb	*Tx4Urb;
+	struct urb	*Tx2Urb;
 
 	int		EP2VM_status;
 	int		EP4VM_status;
 
-	u32	TxFillCount; // 20060928
-	u32	TxTimer; // 20060928 Add if sending packet not great than 13
+	u32		TxFillCount; /* 20060928 */
+	u32		TxTimer; /* 20060928 Add if sending packet not great than 13 */
 };
 
 #endif
-- 
1.7.7.3




More information about the devel mailing list