[PATCH 3/3] Fix line over 80 character issue and space before tabs issue in trace.h

YAMANE Toshiaki yamanetoshi at gmail.com
Tue Oct 2 11:54:48 UTC 2012


fixed some checkpatch warnings.

-WARNING: line over 80 characters
-WARNING: please, no space before tabs

Signed-off-by: Toshiaki Yamane <yamanetoshi at gmail.com>
---
 drivers/staging/rts_pstor/trace.h |   62 ++++++++++++++++++++-----------------
 1 file changed, 34 insertions(+), 28 deletions(-)

diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h
index a34493c..fdc48cc 100644
--- a/drivers/staging/rts_pstor/trace.h
+++ b/drivers/staging/rts_pstor/trace.h
@@ -46,36 +46,42 @@ static inline char *filename(char *path)
 	return path;
 }
 
-#define TRACE_RET(chip, ret)   										\
-do {													\
-	char *_file = filename(__FILE__);								\
-	RTSX_DEBUGP("[%s][%s]:[%d]\n", _file, __func__, __LINE__);					\
-	(chip)->trace_msg[(chip)->msg_idx].line = (u16)(__LINE__);					\
-	strncpy((chip)->trace_msg[(chip)->msg_idx].func, __func__, MSG_FUNC_LEN-1);			\
-	strncpy((chip)->trace_msg[(chip)->msg_idx].file, _file, MSG_FILE_LEN-1); 			\
-	get_current_time((chip)->trace_msg[(chip)->msg_idx].timeval_buf, TIME_VAL_LEN);			\
-	(chip)->trace_msg[(chip)->msg_idx].valid = 1;							\
-	(chip)->msg_idx++; 										\
-	if ((chip)->msg_idx >= TRACE_ITEM_CNT) { 							\
-		(chip)->msg_idx = 0;									\
-	}												\
-	return ret; 											\
+#define TRACE_RET(chip, ret) \
+do { \
+	char *_file = filename(__FILE__); \
+	RTSX_DEBUGP("[%s][%s]:[%d]\n", _file, __func__, __LINE__); \
+	(chip)->trace_msg[(chip)->msg_idx].line = (u16)(__LINE__); \
+	strncpy((chip)->trace_msg[(chip)->msg_idx].func, \
+		__func__, MSG_FUNC_LEN-1); \
+	strncpy((chip)->trace_msg[(chip)->msg_idx].file, \
+		_file, MSG_FILE_LEN-1); \
+	get_current_time((chip)->trace_msg[(chip)->msg_idx].timeval_buf, \
+			 TIME_VAL_LEN); \
+	(chip)->trace_msg[(chip)->msg_idx].valid = 1; \
+	(chip)->msg_idx++; \
+	if ((chip)->msg_idx >= TRACE_ITEM_CNT) { \
+		(chip)->msg_idx = 0; \
+	} \
+	return ret; \
 } while (0)
 
-#define TRACE_GOTO(chip, label)   									\
-do {													\
-	char *_file = filename(__FILE__);								\
-	RTSX_DEBUGP("[%s][%s]:[%d]\n", _file, __func__, __LINE__);					\
-	(chip)->trace_msg[(chip)->msg_idx].line = (u16)(__LINE__);					\
-	strncpy((chip)->trace_msg[(chip)->msg_idx].func, __func__, MSG_FUNC_LEN-1);			\
-	strncpy((chip)->trace_msg[(chip)->msg_idx].file, _file, MSG_FILE_LEN-1); 			\
-	get_current_time((chip)->trace_msg[(chip)->msg_idx].timeval_buf, TIME_VAL_LEN);			\
-	(chip)->trace_msg[(chip)->msg_idx].valid = 1;							\
-	(chip)->msg_idx++; 										\
-	if ((chip)->msg_idx >= TRACE_ITEM_CNT) { 							\
-		(chip)->msg_idx = 0;									\
-	}												\
-	goto label; 											\
+#define TRACE_GOTO(chip, label) \
+do { \
+	char *_file = filename(__FILE__); \
+	RTSX_DEBUGP("[%s][%s]:[%d]\n", _file, __func__, __LINE__); \
+	(chip)->trace_msg[(chip)->msg_idx].line = (u16)(__LINE__); \
+	strncpy((chip)->trace_msg[(chip)->msg_idx].func, \
+		__func__, MSG_FUNC_LEN-1); \
+	strncpy((chip)->trace_msg[(chip)->msg_idx].file, \
+		_file, MSG_FILE_LEN-1); \
+	get_current_time((chip)->trace_msg[(chip)->msg_idx].timeval_buf, \
+			 TIME_VAL_LEN); \
+	(chip)->trace_msg[(chip)->msg_idx].valid = 1; \
+	(chip)->msg_idx++; \
+	if ((chip)->msg_idx >= TRACE_ITEM_CNT) { \
+		(chip)->msg_idx = 0; \
+	} \
+	goto label; \
 } while (0)
 #else
 #define TRACE_RET(chip, ret)	return(ret)
-- 
1.7.9.5




More information about the devel mailing list