[PATCH 1/1] staging: gdm72xx: Remove redundant null check before kfree in gdm_wimax.c

Greg KH gregkh at linuxfoundation.org
Wed Nov 21 21:51:18 UTC 2012


On Wed, Nov 21, 2012 at 08:38:29PM +0530, Sachin Kamat wrote:
> On 21 November 2012 14:47, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> > On Wed, Nov 21, 2012 at 11:29:36AM +0530, Sachin Kamat wrote:
> >> kfree on a null pointer is a no-op.
> >>
> >
> > kdelete() used to accept NULL pointers but now it will oops.
> 
> You are right. We can either leave it the way it was (i.e. drop this
> patch) or I remove the NULL assignment
> and re-send?

Look at the code and determine what needs to be done.

thanks,

greg k-h



More information about the devel mailing list