[PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c
Dan Carpenter
dan.carpenter at oracle.com
Tue Nov 20 14:16:45 UTC 2012
On Tue, Nov 20, 2012 at 12:09:57PM +0000, Rupesh Gujare wrote:
> 2. We can save few CPU cycles by checking NULL pointer here, rather
> than relying on kfree().
I'm not sure about that.
But more importantly does any of the memory pools code actually make
a difference in benchmarks? What is the difference between running
with OZ_MAX_TX_POOL_SIZE as zero and it set to 6? We have this
very complicated code with spinlocks and linked lists to save six
56 byte allocations... It's silly. :P Just use kmalloc().
regards,
dan carpenter
More information about the devel
mailing list