[PATCH] staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user()
Kumar amit mehta
gmate.amit at gmail.com
Mon Nov 19 13:08:29 UTC 2012
On Mon, Nov 19, 2012 at 02:15:54PM +0300, Dan Carpenter wrote:
> On Mon, Nov 19, 2012 at 04:25:31PM +0530, Kumar Amit Mehta wrote:
> > -- fix for missing audits for return values of get_user() and put_user().
> > -- Remove the TIOCSSOFTCAR ioctl handling from dgrp driver.
>
> These should be done in separate commits.
>
> Are the calls to access_ok() still needed if we check get_user() and
> put_user()?
>
You are right, access_ok() would become redundant if we check get/put_user().
Also, After sending one patch for removing TIOCSSOFTCAR ioctl handler from dgrp
driver, I realized that I should be sending two patches as patch series. Please
correct me if I'm wrong.
Regards,
Amit
More information about the devel
mailing list