[PATCH] ipack: move header files to include/linux

Greg Kroah-Hartman gregkh at linuxfoundation.org
Fri Nov 16 19:04:06 UTC 2012


On Fri, Nov 16, 2012 at 07:14:15PM +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2012-11-16 at 10:08 -0800, Joe Perches wrote:
> > On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote:
> > > Move ipack header files to include/linux/ directory where they belong to.
> > 
> > Why do these belong in include/linux?
> 
> They are used for other drivers that could be in other directories.
> 
> > What's wrong with path relative includes?
> 
> There is nothing wrong with relative includes. It's just to do the
> things as other subsystems do: keeping the bus' header file in
> include/linux directory.
> 
> Is this approach wrong for this case?

No, not at all, this is fine.

thanks,

greg k-h



More information about the devel mailing list