[PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback() in serqt_usb2.c
YAMANE Toshiaki
yamanetoshi at gmail.com
Thu Nov 15 20:53:11 UTC 2012
On Fri, Nov 16, 2012 at 5:43 AM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
>
> Btw:
>> + dev_dbg(&port->dev, "Line status status.\n");
> ^^^^^^^^^^^^^^^^^^^
> These kind of debug statements which just tell which function is
> being called can be deleted. The function tracer already provides
> that information.
I did not know that. Thanks!
>> + fn = ProcessLineStatus;
>> + } else {
>> + dev_dbg(&port->dev, "Modem status status.\n");
>> + fn = ProcessModemStatus;
>
> regards,
> dan carpenter
>
--
Regards,
YAMANE Toshiaki
More information about the devel
mailing list