[PATCH 3/7] staging: comedi: amplc_dio200: Remove forward function declarations

H Hartley Sweeten hartleys at visionengravers.com
Thu May 31 16:37:39 UTC 2012


On Thursday, May 31, 2012 6:09 AM, Ian Abbott wrote:
> Moved some functions and variables to avoid forward declarations.  Moved
> PCI table closer to the struct pci_driver that refers to it.
>
> Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
> ---
>  drivers/staging/comedi/drivers/amplc_dio200.c |  105 +++++++++++-------------
>  1 files changed, 48 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/amplc_dio200.c b/drivers/staging/comedi/drivers/amplc_dio200.c
> index 2167697..daf5e52 100644
> --- a/drivers/staging/comedi/drivers/amplc_dio200.c
> +++ b/drivers/staging/comedi/drivers/amplc_dio200.c

<snip>

> +/*
> + * The struct comedi_driver structure tells the Comedi core module
> + * which functions to call to configure/deconfigure (attach/detach)
> + * the board, and also about the kernel module that contains
> + * the device code.
> + */

It makes some sense to leave this comment in the skel driver but
I don't think it's needed in the actual comedi drivers. 

Regards,
Hartley




More information about the devel mailing list