[PATCH 9/9] staging: comedi: das08: Add attach_pci() hook

Ian Abbott abbotti at mev.co.uk
Thu May 24 15:15:38 UTC 2012


On 2012-05-23 21:22, Dan Carpenter wrote:
> On Wed, May 23, 2012 at 05:50:28PM +0100, Ian Abbott wrote:
>> +
>> +#if IS_ENABLED(CONFIG_COMEDI_DAS08_PCI)
>> +static const struct das08_board_struct
>> +*das08_find_pci_board(struct pci_dev *pdev)
>
> Normally the * would go on the first line.
>
> static const struct das08_board_struct *
> das08_find_pci_board(struct pci_dev *pdev)
>
> That way before cscope was around you can grep for functions by
> doing:  egrep -B1 '^[a-z]+\(' *.c
>
> There are 30 some places in the kernel which put the * on the second
> line but they are mostly in ugly subsystems.

CodingStyle section 3.1 suggests it should be adjacent to the function name.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list