[PATCH 6/9] staging: comedi: das08: Replace printk calls

[Ian Abbott]

On 2012-05-23 20:58, Dan Carpenter wrote:
> On Wed, May 23, 2012 at 12:58:13PM -0500, H Hartley Sweeten wrote:
>> On Wednesday, May 23, 2012 9:50 AM, Ian Abbott wrote:

>>> @@ -839,10 +838,10 @@ int das08_common_attach(struct comedi_device *dev, unsigned long iobase)
>>>   	case isa:
>>>   	case pc104:
>>>   		/*  allocate ioports for ISA (and PC/104) boards */
>>> -		printk(KERN_INFO " iobase 0x%lx\n", iobase);
>>> +		dev_info(dev->class_dev, "iobase 0x%lx\n", iobase);
>>>   		if (!request_region(iobase, thisboard->iosize,
>>>   				    dev->driver->driver_name)) {
>>> -			printk(KERN_ERR " I/O port conflict\n");
>>> +			dev_err(dev->class_dev "I/O port conflict\n");
>>
>> Missing a comma after class_dev.
>>
>
> And this would have been caught at compile time if everything
> weren't ifdefed to death.

Yes, I really should have compiled that one for a kernel with ISA bus 
support!  I'll do that before resubmitting the patches.

I'm not really sure how to deal with these hybrid drivers other than 
ifdefing them to deaf.  Fortunately there aren't very many of them.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-