[PATCH 3/8] Staging: ipack/bridges/tpci200: tpci200_slot_unmap_space() should return 0 if succeed.
Dan Carpenter
dan.carpenter at oracle.com
Wed May 23 14:25:03 UTC 2012
On Wed, May 23, 2012 at 03:54:42PM +0200, Samuel Iglesias Gonsalvez wrote:
> tpci200_slot_unmap_space() should return 0 if the operation was properly done. If
> not, the caller will think that something wrong happened.
>
It's weird and frustrating that gcc didn't warn that we used "res"
without initializing it. It feels like the goto out_unlock places
should return an error. But actually the callers don't don't check
the return values so I guess it doesn't matter.
All these patches look good.
regards,
dan carpenter
More information about the devel
mailing list