[PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void __iomem *
abbotti at mev.co.uk
Tue May 22 10:15:12 UTC 2012
On 2012-05-22 09:11, Dan Carpenter wrote:
> On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote:
>> @@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev,
>> if (ret< 0)
>> return ret;
>> - devpriv->ioaddr = (void *)(unsigned long)it->options;
>> + devpriv->ioaddr = (void __iomem *)(unsigned long)it->options;
> Obviously, your patch is fine, but I was wondering if it was a
> problem that it->options was only a 32 bit? Seems like it would
> deserve a comment.
Yes, it's a bit of a strange driver, this one. It's a driver for a
module sitting on a PCI card, but there is no driver I know of for the
PCI card, and I've no idea what's actually ioremap'ing the memory!
Maybe we should quietly drop it and see if anyone complains?
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti at mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
More information about the devel