[PATCH] Staging: android: alarm: Renamed pr_alarm to alarm_dbg

Nasir Abed nasirabed+kernel at gmail.com
Mon May 21 21:04:27 UTC 2012


Hi Joe,

> Welcome to linux-kernel developing.
>
Thanks.

> It's generally pretty unnecessary to resubmit a variant of
> a patch that someone else has already submitted.
>
My mistake I should have double checked that first.

> If you want to get your 2nd patch in, that's great, but
> please consider doing work that isn't just checkpatch
> cleanups and isn't duplicative of work where you were cc'd.
>
That doesn't really sounds encouraging. Greg Kroah-Hartman
presentation on writing and submitting your (first) patch was my
inspiration to start helping out. However what you are saying might
scare away potential new developers.

> diff --git a/drivers/staging/android/alarm.c b/drivers/staging/android/alarm.c
>
> Is this done against -next or some other -staging tree?
>
I am using: http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Thanks for your feedback, very helpful.

Cheers,

Nasir Abed



More information about the devel mailing list