[PATCH 1/5] Staging ipack: fix a few sparse warnings

Samuel Iglesias Gonsálvez siglesias at igalia.com
Mon May 14 12:53:36 UTC 2012


On Mon, 2012-05-14 at 15:26 +0300, Dan Carpenter wrote:
> On Mon, May 14, 2012 at 12:41:25PM +0200, Samuel Iglesias Gonsalvez wrote:
> >  	/* Read status register */
> > -	status_reg = readw((unsigned short *) (tpci200->info->interface_regs +
> > +	status_reg = readw((void __iomem *) (tpci200->info->interface_regs +
> >  					       TPCI200_STATUS_REG));
> >  
> 
> Later in the patch, you do the right thing which is to declare this
> as an __iomem pointer in the header.  The cast here can be removed
> and it all fits on one line.
> 
> Remove it in a follow on patch if you want.  Same for several of the
> other casts in this patch.

Thanks a lot. I will do it.

Regards,

Sam


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120514/a885a660/attachment.asc>


More information about the devel mailing list