staging: sep: reworked crypto layer

Dan Carpenter dan.carpenter at oracle.com
Sun May 13 18:44:52 UTC 2012


Hello Mark A. Allyn,

This is a semi-automatic email about new static checker warnings.

The patch 9196dc1129fb: "staging: sep: reworked crypto layer" from 
Feb 10, 2012, leads to the following static checker complaint:

drivers/staging/sep/sep_crypto.c:2272 sep_hash_update()
	 warn: variable dereferenced before check 'ta_ctx->src_sg' (see line 2270)

drivers/staging/sep/sep_crypto.c
  2269	
  2270		src_ptr = sg_virt(ta_ctx->src_sg);
                                  ^^^^^^^^^^^^^^
Dereferenced inside sg_virt() function (new).

  2271	
  2272		if ((!req->nbytes) || (!ta_ctx->src_sg)) {
                                        ^^^^^^^^^^^^^^
Checked for NULL (new).

  2273			/* null data */
  2274			src_ptr = NULL;

Same thing in the sep_hash_digest() function.
drivers/staging/sep/sep_crypto.c:2505 sep_hash_digest() warn:
	variable dereferenced before check 'ta_ctx->src_sg' (see line 2503)

These is sort of an older warning, and I haven't released the Smatch
changes to detect it publically yet.

regards,
dan carpenter




More information about the devel mailing list