[PATCH 23/25] Staging: comedi: fix printk issue in poc.c
Ravishankar Karkala Mallikarjunayya
ravishankarkm32 at gmail.com
Fri May 11 10:38:11 UTC 2012
This is a patch to the poc.c file that fixes up a
printk warning found by the checkpatch.pl tool.
Converted printks to dev_<level> function.
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km at greenturtles.in>
---
drivers/staging/comedi/drivers/poc.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c
index e3690bb..a55b877 100644
--- a/drivers/staging/comedi/drivers/poc.c
+++ b/drivers/staging/comedi/drivers/poc.c
@@ -142,21 +142,22 @@ static int poc_attach(struct comedi_device *dev, struct comedi_devconfig *it)
unsigned int iosize;
iobase = it->options[0];
- printk(KERN_INFO "comedi%d: poc: using %s iobase 0x%lx\n", dev->minor,
- this_board->name, iobase);
+ dev_info(dev->hw_dev, "comedi%d: poc: using %s iobase 0x%lx\n",
+ dev->minor, this_board->name, iobase);
dev->board_name = this_board->name;
if (iobase == 0) {
- printk(KERN_ERR "io base address required\n");
+ dev_err(dev->hw_dev, "io base address required\n");
return -EINVAL;
}
iosize = this_board->iosize;
/* check if io addresses are available */
if (!request_region(iobase, iosize, "dac02")) {
- printk(KERN_ERR "I/O port conflict: failed to allocate ports "
- "0x%lx to 0x%lx\n", iobase, iobase + iosize - 1);
+ dev_err(dev->hw_dev,
+ "I/O port conflict: failed to allocate ports 0x%lx to 0x%lx\n",
+ iobase, iobase + iosize - 1);
return -EIO;
}
dev->iobase = iobase;
@@ -187,7 +188,7 @@ static int poc_detach(struct comedi_device *dev)
if (dev->iobase)
release_region(dev->iobase, this_board->iosize);
- printk(KERN_INFO "comedi%d: dac02: remove\n", dev->minor);
+ dev_info(dev->hw_dev, "comedi%d: remove\n", dev->minor);
return 0;
}
--
1.7.0.4
More information about the devel
mailing list