[PATCH 14/25] Staging: comedi: fix printk issue in serial2002.c

Ravishankar Karkala Mallikarjunayya ravishankarkm32 at gmail.com
Fri May 11 10:38:02 UTC 2012


This is a patch to the serial2002.c file that fixes up a
printk warning found by the checkpatch.pl tool.

This patch converts a printks to pr_<level> and used dev_<level>
function wherver possible.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km at greenturtles.in>
---
 drivers/staging/comedi/drivers/serial2002.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c
index a034b10..5a5a781 100644
--- a/drivers/staging/comedi/drivers/serial2002.c
+++ b/drivers/staging/comedi/drivers/serial2002.c
@@ -287,7 +287,7 @@ static struct serial_data serial_read(struct file *f, int timeout)
 
 		length++;
 		if (data < 0) {
-			printk(KERN_ERR "serial2002 error\n");
+			pr_err("serial2002 error\n");
 			break;
 		} else if (data & 0x80) {
 			result.value = (result.value << 7) | (data & 0x7f);
@@ -360,7 +360,7 @@ static int serial_2002_open(struct comedi_device *dev)
 	devpriv->tty = filp_open(port, O_RDWR, 0);
 	if (IS_ERR(devpriv->tty)) {
 		result = (int)PTR_ERR(devpriv->tty);
-		printk(KERN_ERR "serial_2002: file open error = %d\n", result);
+		dev_err(dev->hw_dev, "file open error = %d\n", result);
 	} else {
 		struct config_t {
 
-- 
1.7.0.4




More information about the devel mailing list