[PATCH 1/2] staging/comedi/drivers: add driver for ad7739 analog

Dan Carpenter dan.carpenter at oracle.com
Tue Mar 20 08:00:00 UTC 2012


On Tue, Mar 20, 2012 at 11:46:19AM +0400, Alexander Pazdnikov wrote:
> Thank you, Dan, for your comments.
> 
> > > +/*
> > > +    Usage example through board-setup.
> > > +static const struct ad7739_platform_data dd11_adc =.{
> > ^
> > Remove the typo extra period.
> 
> Other driver headers in include/linux/platform_data use the form
> MY_DRIVER_NAME_platform_data, so in my opinion, it is best to stay
> as they are.
> 

What I'm saying is there is a typo.  It should be "dd11_adc = {" not
"dd11_adc =.{".

> > > +
> > > +	if (alloc_private(dev, sizeof(struct ad7739_private)) < 0)
> > > +		return -ENOMEM;
> > 
> > ret = alloc_private(dev, sizeof(struct ad7739_private));
> > if (ret)
> > return ret;
> 
> Thank you, I've investigated other comedi drivers, some of them
> use such handling for comedi specific functions
> 
> if (ret < 0)
>     return ret;
> 
> so, in my point of view, it is best to use generally accepted way\
> in comedi_lib, thank you for pointing that out.
> 

Either way is fine with me.  You get to pick.

regards,
dan carpenter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120320/edc6aca9/attachment.asc>


More information about the devel mailing list