[PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock.

santosh nayak santoshprasadnayak at gmail.com
Fri Mar 16 16:23:58 UTC 2012


From: Santosh Nayak <santoshprasadnayak at gmail.com>

In s2250_probe(), If locking attempt is interrupted by a signal then
it should return -EINTR after unregistering audio device and making free
the allocated memory.

At present, if locking is interrupted by signal it will display message
"initialized successfully" and return success.  This is wrong.

Signed-off-by: Santosh Nayak <santoshprasadnayak at gmail.com>
---
 drivers/staging/media/go7007/s2250-board.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/media/go7007/s2250-board.c b/drivers/staging/media/go7007/s2250-board.c
index 014d384..2823bbf 100644
--- a/drivers/staging/media/go7007/s2250-board.c
+++ b/drivers/staging/media/go7007/s2250-board.c
@@ -657,6 +657,10 @@ static int s2250_probe(struct i2c_client *client,
 			kfree(data);
 		}
 		mutex_unlock(&usb->i2c_lock);
+	} else {
+		i2c_unregister_device(audio);
+		kfree(state);
+		return -EINTR;
 	}
 
 	v4l2_info(sd, "initialized successfully\n");
-- 
1.7.4.4




More information about the devel mailing list