[PATCH 1/3] Drivers: hv: Support the newly introduced KVP messages in the driver
dan.carpenter at oracle.com
Fri Mar 16 05:45:56 UTC 2012
On Thu, Mar 15, 2012 at 05:48:43PM -0700, K. Y. Srinivasan wrote:
> * The windows host expects the key/value pair to be encoded
> * in utf16.
> keylen = utf8s_to_utf16s(key_name, strlen(key_name), UTF16_HOST_ENDIAN,
> - (wchar_t *) kvp_data->data.key,
> + (wchar_t *) kvp_data->key,
> HV_KVP_EXCHANGE_MAX_KEY_SIZE / 2);
> - kvp_data->data.key_size = 2*(keylen + 1); /* utf16 encoding */
> + kvp_data->key_size = 2*(keylen + 1); /* utf16 encoding */
I feel like a jerk for asking this, but is the output length correct
here? It seems like we could go over again. Also utf8s_to_utf16s()
can return negative error codes, why do we ignore those?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the devel