[PATCH 1/3] Add r/w sysfs attribute for zcache_freeze

Dan Magenheimer dan.magenheimer at oracle.com
Thu Mar 15 17:54:30 UTC 2012


> From: Florian Schmaus [mailto:fschmaus at gmail.com]
> Subject: Re: [PATCH 1/3] Add r/w sysfs attribute for zcache_freeze
> 
> On 03/15/12 17:37, Konrad Rzeszutek Wilk wrote:
> > On Tue, Mar 13, 2012 at 11:34:46AM +0100, Florian Schmaus wrote:
> >> From: Andor Daam<andor.daam at googlemail.com>
> >>
> >> This patch makes dynamic enabling/disabling of zcache via a sysfsnode possible.
> > There should be an patch to the Documentation/ABI/testing for these parameters.
> Agreed. Currently none of the modifiable zcache parameters has any
> Documentation in ABI/testing, including:
> - zv_max_zsize
> - zv_max_mean_zsize
> - zv_page_count_policy
> 
> We are also thinking about providing a patch that moves all read only
> zcache sysfs attributes into debugfs, so that the debug values from
> cleancache, frontswap and zcache are all within /sys/kernel/debug. It
> has also the advantage that if one doesn't want the performance impact
> of those counters, he could easily compile zcache without them.

That would be very useful.  Moving all the sysfs code into debugfs
will be a necessary step before zcache can be promoted out of staging.

> This patch could also include the missing Documentation.

Is there a place to document debugfs variables?  I think the
Documentation/ABI is only necessary for sysfs.

Dan



More information about the devel mailing list