[PATCH 1/1] Drivers: scsi: storvsc: Don't pass ATA_16 command to the host

James Bottomley James.Bottomley at HansenPartnership.com
Sun Mar 4 14:19:30 UTC 2012

On Fri, 2012-03-02 at 12:49 -0800, K. Y. Srinivasan wrote:
> Windows hosts don't handle the ATA_16 command; don't pass it to the host.

What do you mean by this?  Most SCSI devices don't handle ATA_16 because
it's only useful if the device is actually an ATA device behind a

As a general rule, you shouldn't filter in the driver commands you think
the host won't want to see, you should let the host reply with an error
code.  You should *only* filter commands that cause an actual bug in the
host.  Is the latter the case for this command (if so that needs to be

> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com>

This signoff chain doesn't make sense, since you're sending me the patch
and apparently you authored it.


More information about the devel mailing list