[PATCH 4/6] staging: ozwpan: set last_pkt_nb

Rupesh Gujare rgujare at ozmodevices.com
Tue Jun 26 09:34:26 UTC 2012


On 23/06/12 10:39, Dan Carpenter wrote:
> On Wed, Jun 20, 2012 at 01:36:09PM +0100, Rupesh Gujare wrote:
>> In case of trigeered ISOC mode set last_pkt_nb only when
>> we are ready to send data.
>>
>> Signed-off-by: Rupesh Gujare <rgujare at ozmodevices.com>
>> ---
>>   drivers/staging/ozwpan/ozpd.c |    9 +++++++++
>>   1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
>> index 6c566f5..25a8a08 100644
>> --- a/drivers/staging/ozwpan/ozpd.c
>> +++ b/drivers/staging/ozwpan/ozpd.c
>> @@ -420,6 +420,14 @@ void oz_set_more_bit(struct sk_buff *skb)
>>   	oz_hdr->control |= OZ_F_MORE_DATA;
>>   }
>>   /*------------------------------------------------------------------------------
>> + * Context: softirq-serialized
>> + */
>> +void oz_set_last_pkt_nb(struct oz_pd *pd, struct sk_buff *skb)
>> +{
>> +	struct oz_hdr *oz_hdr = (struct oz_hdr *)skb_network_header(skb);
>> +	oz_hdr->last_pkt_num = pd->trigger_pkt_num & OZ_LAST_PN_MASK;
>> +}
>> +/*------------------------------------------------------------------------------
> These patches were already applied, but don't do these ------------
> lines.  Use normal kernel multi-line comment style or even better do
> it in doc-book format.  It is described in
> Documentation/kernel-doc-nano-HOWTO.txt.
>
> Put a blank line after the end of each function.
>
>
>
Thanks Dan,

I agree that it is probably not good idea to add ---------- lines.
However these were added to keep code commenting consistent with rest of 
code.

I will take care that, next patches adhere to multi-line comment style.

-- 
Regards,
Rupesh Gujare





More information about the devel mailing list