[PATCH 06/33] staging: comedi: cb_das16_cs: cleanup the pcmcia_driver declaration

H Hartley Sweeten hartleys at visionengravers.com
Mon Jun 25 22:57:49 UTC 2012


For aesthetic reasons, add some whitespace to the declaration
of the pcmcia_driver and reorder it a bit.

Also, the symbol 'das16cs_driver' is only referenced in this file,
make it static. This quiets the following sparse warning:

warning: symbol 'das16cs_driver' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Frank Mori Hess <fmhess at users.sourceforge.net>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/cb_das16_cs.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/comedi/drivers/cb_das16_cs.c b/drivers/staging/comedi/drivers/cb_das16_cs.c
index 625134f..2ac30f4 100644
--- a/drivers/staging/comedi/drivers/cb_das16_cs.c
+++ b/drivers/staging/comedi/drivers/cb_das16_cs.c
@@ -770,14 +770,14 @@ static const struct pcmcia_device_id das16cs_id_table[] = {
 
 MODULE_DEVICE_TABLE(pcmcia, das16cs_id_table);
 
-struct pcmcia_driver das16cs_driver = {
-	.probe = das16cs_pcmcia_attach,
-	.remove = das16cs_pcmcia_detach,
-	.suspend = das16cs_pcmcia_suspend,
-	.resume = das16cs_pcmcia_resume,
-	.id_table = das16cs_id_table,
-	.owner = THIS_MODULE,
-	.name = "cb_das16_cs",
+static struct pcmcia_driver das16cs_driver = {
+	.name		= "cb_das16_cs",
+	.owner		= THIS_MODULE,
+	.probe		= das16cs_pcmcia_attach,
+	.remove		= das16cs_pcmcia_detach,
+	.suspend	= das16cs_pcmcia_suspend,
+	.resume		= das16cs_pcmcia_resume,
+	.id_table	= das16cs_id_table,
 };
 
 static int __init das16cs_init(void)
-- 
1.7.11




More information about the devel mailing list