[PATCH] drivers: staging: android: fix binder.c printk macros
gregkh at linuxfoundation.org
Mon Jun 25 17:24:23 UTC 2012
On Mon, Jun 25, 2012 at 10:20:00AM -0700, Joe Perches wrote:
> On Mon, 2012-06-25 at 10:17 -0700, Greg KH wrote:
> > On Sat, Jun 23, 2012 at 02:09:41AM -0400, Sherwin Soltani wrote:
> > > Changed to pr_warn, pr_err, and pr_info macros and reformatted some
> > > lines to bring them under the 80 column limit in the binder.c code.
> > >
> > > Signed-off-by: Sherwin Soltani <sherwin at wybc.com>
> > > ---
> > > drivers/staging/android/binder.c | 74 ++++++++++++++++++++------------------
> > > 1 file changed, 40 insertions(+), 34 deletions(-)
> > Hi,
> > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> > a patch that has triggered this response. He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created. Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> > --- Your patch did many different things all at once, making it
> > difficult to review.
> Your patch-bot needs work.
> Converting printks to pr_<level> is trivial
> and should be done all at once, not piecemeal.
I'm not disagreeing with that, unfortunately this patch also did more
than just pr_<level> conversions, which is why my patch-bot kicked in.
So your patch-bot complaint generator needs work :)
More information about the devel