[PATCH 2/6] staging: ozwpan: Correct ioctl numbers.

Rupesh Gujare rgujare at ozmodevices.com
Thu Jun 21 10:00:08 UTC 2012


On 21/06/12 00:04, Greg KH wrote:
> On Wed, Jun 20, 2012 at 01:36:07PM +0100, Rupesh Gujare wrote:
>> ioctl numbers were not in order, rearranging them in ascending order.
>>
>> Signed-off-by: Rupesh Gujare<rgujare at ozmodevices.com>
>> ---
>>   drivers/staging/ozwpan/ozappif.h |    6 +++---
>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/ozwpan/ozappif.h b/drivers/staging/ozwpan/ozappif.h
>> index 1b59b07..449a6ba 100644
>> --- a/drivers/staging/ozwpan/ozappif.h
>> +++ b/drivers/staging/ozwpan/ozappif.h
>> @@ -30,9 +30,9 @@ struct oz_binding_info {
>>   #define OZ_IOCTL_GET_PD_LIST	_IOR(OZ_IOCTL_MAGIC, 0, struct oz_pd_list)
>>   #define OZ_IOCTL_SET_ACTIVE_PD	_IOW(OZ_IOCTL_MAGIC, 1, struct oz_mac_addr)
>>   #define OZ_IOCTL_GET_ACTIVE_PD	_IOR(OZ_IOCTL_MAGIC, 2, struct oz_mac_addr)
>> -#define OZ_IOCTL_ADD_BINDING	_IOW(OZ_IOCTL_MAGIC, 5, struct oz_binding_info)
>> -#define OZ_IOCTL_REMOVE_BINDING	_IOW(OZ_IOCTL_MAGIC, 8, struct oz_binding_info)
>> -#define OZ_IOCTL_MAX		9
>> +#define OZ_IOCTL_ADD_BINDING	_IOW(OZ_IOCTL_MAGIC, 3, struct oz_binding_info)
>> +#define OZ_IOCTL_REMOVE_BINDING	_IOW(OZ_IOCTL_MAGIC, 4, struct oz_binding_info)
>> +#define OZ_IOCTL_MAX		5
> Really?  You just might have broken any userspace applications that were
> compiled against the old header.
>
> I'll go apply this, but you need to be aware that you just broke the
> user/kernel api here...
>
> greg k-h
>

Thanks Greg, for accepting this patch.

Yes, I am aware that this might break userspace application, However at 
the moment we are also maintaining userspace application for this driver 
& care have been taken to take this change into account.

-- 
Regards,
Rupesh Gujare





More information about the devel mailing list