[PATCH] staging: zsmalloc: Finish conversion to a separate module

Ben Hutchings ben at decadent.org.uk
Wed Jun 20 01:58:22 UTC 2012


On Tue, 2012-06-19 at 20:46 -0500, Jonathan Nieder wrote:
> (+cc: devel at driverdev)
> Hi Ben,
> 
> Ben Hutchings wrote:
> 
> > ZSMALLOC is tristate, but the code has no MODULE_LICENSE and since it
> > depends on GPL-only symbols it cannot be loaded as a module.  This in
> > turn breaks zram which now depends on it.  I assume it's meant to be
> > Dual BSD/GPL like the other z-stuff.
> 
> Yep, the opening comment in the file says so.
> 
> > There is also no module_exit, which will make it impossible to unload.
> > Add the appropriate module_init and module_exit declarations suggested
> > by comments.
> >
> > Reported-by: Christian Ohm <chr.ohm at gmx.net>
> 
> I sent a similar patch + fixup last week[*].  Yours has a clearer
> description.  The only other difference aside from reordering lines is
> that I marked zs_init as __init and zs_exit as __exit.

Ah, but you made the mistake of marking it 'RFC'. :-)

> [...]
> > This is compile-tested only.
> 
> Someone using zram tested last week's patch (which is almost
> identical) against 3.4.y and let me know it worked by private email,
> but I don't have permission to name that person.
> 
> So for what it's worth,
> Reviewed-by: Jonathan Nieder <jrnieder at gmail.com>

Thanks.

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program than vice versa.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120620/c6c6a649/attachment.asc>


More information about the devel mailing list