[PATCH 4/7] pstore/ram_core: Better ECC size checking

Kees Cook keescook at chromium.org
Tue Jun 19 18:44:01 UTC 2012


On Mon, Jun 18, 2012 at 7:15 PM, Anton Vorontsov
<anton.vorontsov at linaro.org> wrote:
> - Instead of exploiting unsigned overflows (which doesn't work for all
>  sizes), use straightforward checking for ECC total size not exceeding
>  initial buffer size;
>
> - Printing overflowed buffer_size is not informative. Instead, print
>  ecc_size and buffer_size;
>
> - No need for buffer_size argument in persistent_ram_init_ecc(),
>  we can address prz->buffer_size directly.
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov at linaro.org>

Acked-by: Kees Cook <keescook at chromium.org>

-- 
Kees Cook
Chrome OS Security



More information about the devel mailing list