[PATCH] Staging: comedi: fixed warning message prefer pr_err in ni_labpc.c This is a patch to the ni_labpc.c file that fixes up several 'prefer pr_err' warnings found by the checkpatch.pl tool

Dan Carpenter dan.carpenter at oracle.com
Thu Jun 14 13:11:14 UTC 2012


There are a lot of problems with this patch...  :/

The subject is messed up.  Hint put a blank line between the subject
and the body of the changelog.  Send it to yourself first and try
applying it with git am.  Only make one kind of change per patch.
There is no signed off by line.  That's not how pr_err() is supposed
to be used.  Look through the other files for examples of correct
usage.  The multi-line commenting style should match
Documentation/CodingStyle.  The blank spaces at the start of the
error messages are not wanted.

regards,
dan carpenter





More information about the devel mailing list